Add a flag to include ros2_control tag #247
Open
+102
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any update on when this will be merged? it is a needed fix, since there is no support for latest Gazebo versions (gz). |
|
Hello @JafarAbdi, Please make sure to rebase since you introduced conflicts with your PR. Best, |
|
The conflicts are resolved, thanks @vamsikalagaturu |
|
@aalmrad can this be merged quickly? |
|
Hello, Best, |
|
@JafarAbdi this is no longer valid as they updated the gazebo version to latest one. But, there is no flag to disable to enable/disable the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically making it optional to include the
ros2_controltag. Currently, it's not possible to support a simulator not included here (gazebo, ignition, or isaac). For example https://docs.picknik.ai/docs/getting_started/configuration_tutorials/migrate_to_mujoco_config/#use-the-mujocosystem-plugin-in-your-robot-description-xacro-file